Prevent IndexOutOfBoundsException when using translation patches#7
Open
agarciacif wants to merge 1 commit into
Open
Prevent IndexOutOfBoundsException when using translation patches#7agarciacif wants to merge 1 commit into
agarciacif wants to merge 1 commit into
Conversation
Ensures self.values[i] does not exceed the length of textList before setting the combo box value, preventing IndexError during initialization.
Open
Author
The first screenshot shows the additional language added by the fan translation patcher.
The second screenshot illustrates the issue: when the tool reads a language value that falls outside the expected range, the comboBox fails to render correctly.
My fix defaults to the first value (Japanese), ensuring the tool can save the modified data even when the language value is out of range. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying a fan translation patch (e.g., Traducciones-Kurain/PWTrilogy-ESP), the game adds a new language entry. This causes the language value read from languageAddr (0x12D4) to exceed the expected range (> 6). Since the combobox only supports up to index 6, accessing index 7 or higher throws an IndexOutOfBoundsException, preventing the combobox from rendering.
If the language value exceeds the size of textList, default it to 0 to ensure the combobox always renders safely.
I’m not very familiar with savegame handling, but a possible improvement could be to read all textValues directly from the game instead of hardcoding them in arrays. I’m not sure if this is technically possible, but if it is, it could make this solution more flexible.